fix(type-safety): replace manual typeguards with valibot in SPA & reddit-fetch - #3313
Merged
Conversation
…PA and reddit-fetch Replace all `as Record<string, unknown>` casts and manual multi-level typeguard chains with proper valibot schema validation in: - main.ts: Reddit token response, error parsing, jQuery comment URL extraction - reddit-fetch.ts: Reddit auth, listing extraction, user comment fetching Adds RedditTokenSchema, RedditListingSchema, RedditChildDataSchema, and RedditCommentDataSchema with v.safeParse() for all external API data. Closes #3200 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as Record<string, unknown>casts and manual multi-level typeguard chains with valibot schema validation in SPAmain.tsandreddit-fetch.tsRedditTokenSchema,RedditListingSchema,RedditChildDataSchema, andRedditCommentDataSchemawithv.safeParse()for all external Reddit API dataFiles changed
.claude/skills/setup-spa/main.ts— Reddit token auth, error message parsing, jQuery-style comment URL extraction.claude/skills/setup-agent-team/reddit-fetch.ts— Reddit auth, listing/post extraction, user comment fetchingTest plan
bun buildpasses for both files (confirmed locally)ascasts remain in changed files (confirmed:grepreturns zero matches)Closes #3200
Filed from Slack by SPA
🤖 Generated with Claude Code